feat(aap): update tags on inferred spans for API Gateway#704
Open
feat(aap): update tags on inferred spans for API Gateway#704
Conversation
c3a231d to
7e8fea2
Compare
bfb0fc7 to
4e72af5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It updates tags for API Gateway Rest Proxy and HTTP API inferred spans, to enable discovery by both the APM Endpoint Catalog and the API Gateway Catalog:
span.typetowebspan.type: "web"to ensure they are considered as a source for API endpointsoperation_nametagoperation_nametag has been removed from API Gateway inferred spans for consistency with the RFC specificationdd_resource_keywith API Gateway ARNdd_resource_keytag containing the computed API Gateway ARNarn:aws:apigateway:{region}::/restapis/{api-id}arn:aws:apigateway:{region}::/apis/{api-id}Motivation
This PR implements tags updates for RFC-1081.
The goal is be able to use API Gateway lambda inferred spans for endpoint discovery and correlation in the AppSec API Catalog.
Testing Guidelines
Additional Notes
APPSEC-60015
Types of Changes
Check all that apply